Conversation
rdesgroppes
force-pushed
the
regis.desgroppes/adjust-misleading-macos-agent-version-doc
branch
from
0b0baf6 to
b12f686
Compare
After merging #664, I realized the change I introduced to a table could be misinterpreted as suggesting that users should set `datadog_agent_major_version` to values like `7.69-` or `7.70+`, when in fact only `6` or `7` are valid inputs: > When the variable `datadog_macos_download_url` is not set, the official macOS DMG package corresponding to the `datadog_agent_major_version` is used: > > | Agent version | Default macOS DMG package URL | > |-----------------------|-----------------------------------------------------------------| > | 6 | https://install.datadoghq.com/datadog-agent-6-latest.dmg | > | 7.69- | https://install.datadoghq.com/datadog-agent-7-latest.dmg | > | 7.70+ (Intel Mac) | https://install.datadoghq.com/datadog-agent-7-latest.x86_64.dmg | > | 7.70+ (Apple Silicon) | https://install.datadoghq.com/datadog-agent-7-latest.arm64.dmg | Close to its [former state](https://github.com/DataDog/ansible-datadog/blob/e8eb1616e897639c52260cc801439d5bbe7c43df/README.md#macos), the proposed table aims at preventing confusion by separating user-provided configuration values from automatic resolution logic (where version ranges like `7.69-` or `7.70+` are informational only): > | Agent version | Default macOS DMG package URL | > |---------------|---------------------------------------------------------------------------------------| > | 6 | https://install.datadoghq.com/datadog-agent-6-latest.dmg | > | 7 | https://install.datadoghq.com/datadog-agent-7-latest.dmg (7.69-) | > | | https://install.datadoghq.com/datadog-agent-7-latest.x86_64.dmg (7.70+, Intel Mac) | > | | https://install.datadoghq.com/datadog-agent-7-latest.arm64.dmg (7.70+, Apple Silicon) |
rdesgroppes
force-pushed
the
regis.desgroppes/adjust-misleading-macos-agent-version-doc
branch
from
b12f686 to
4ca7461
Compare
swang392
approved these changes
Oct 8, 2025
maycmlee
approved these changes
Oct 8, 2025
swang392
deleted the
regis.desgroppes/adjust-misleading-macos-agent-version-doc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #664, I realized the change I introduced to a table could be misinterpreted as suggesting that users should set
datadog_agent_major_versionto values like7.69-or7.70+, when in fact only6or7are valid inputs:Close to its former state, the proposed table aims at preventing confusion by separating user-provided configuration values from automatic resolution logic (where version ranges like
7.69-or7.70+are informational only):